[Driver][SYCL] Improve deprecation messaging #6282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Certain options are deprecated and will be removed in a future release timeframe. Mark such options as deprecated so they emit a diagnostic stating as such. This was done by adding an additional option flag which can be applied to any option that is deprecated.
elizabethandrews
approved these changes
Jun 9, 2022
smanna12
approved these changes
Jun 9, 2022
pvchupin
approved these changes
Jun 9, 2022
Contributor
pvchupin
left a comment
pvchupin
left a comment
There was a problem hiding this comment.
Thanks Mike for taking care of this!
Contributor
|
@mdtoguchi, can you cross-check please against https://github.com/intel/llvm/blob/sycl/sycl/doc/UsersManual.md and make sure it matches. |
Contributor
Author
|
@pvchupin, all options marked as |
Contributor
|
Pending @hchilama review. |
hchilama
approved these changes
Jun 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain options are deprecated and will be removed in a future release
timeframe. Mark such options as deprecated so they emit a diagnostic
stating as such. This was done by adding an additional option flag
which can be applied to any option that is deprecated.