[SYCL] Fix naming and use of deprecated address spaces #6289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes the following changes. * Adds ext_intel_global_host_space in accordance with the sycl_ext_intel_usm_address_spaces extensions. * Deprecates ext_intel_host_device_space as it was misspelled and has been replaced by ext_intel_global_host_space. * Replaces uses of deprecated address spaces with ext_intel_global_device_space and ext_intel_global_host_space Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Contributor
Author
|
It appears that we had a misspelling in @againull - We may want to include this in the release notes. |
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
aelovikov-intel
approved these changes
Jun 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes the following changes:
ext_intel_global_host_spacein accordance with thesycl_ext_intel_usm_address_spacesextensions.ext_intel_host_device_spaceas it was misspelled and has been replaced byext_intel_global_host_space.ext_intel_global_device_spaceandext_intel_global_host_space