[SYCL] Keep used function declarations during llvm.used removal #6308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is possible for a function declaration to be used by both @llvm.used and, e.g., a spir_func definition. Ensure that we don't attempt to erase such declarations when removing @llvm.used.
bader
reviewed
Jun 15, 2022
Contributor
bader
left a comment
bader
left a comment
There was a problem hiding this comment.
@tcreech-intel, could you add a regression test, please?
Most builds will hit an assertion in the first RUN line when the declaration is incorrectly erased.
Contributor
Author
Hi @bader -- absolutely. Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible for a function declaration to be used by both @llvm.used
and, e.g., a spir_func definition. Ensure that we don't attempt to erase
such declarations when removing @llvm.used.