[SYCL] Reset signalled command list if there no available command list #6314
Conversation
Resetting command lists only in sycnhronization points caused performance regression because we reuse less command lists and new command lists are getting created more often which adds performance overhead. Return the old behavior back: reset signalled command lists each time before requesting a command list to submit a command.
|
|
||
| // We need a command list to submit the command, that's why reset signalled | ||
| // command lists to avoid creating new one. | ||
| resetCommandLists(Queue); |
There was a problem hiding this comment.
this way you are going to check all running fences at each enqueue request whereas previously this check/reset was only done when no command-list was available. should we add this check/shortcut to resetCommandLists?
There was a problem hiding this comment.
I agree, thanks for noticing. Unfortunately, one problem with just adding check/shortcut to resetCommandLists is that available command list may be occupied by another thread as soon as we unlock the queue mutex, so when we reach getAvailableCommandList for the current thread there will be no available command list again.
That's why I returned the old behavior back - reset command lists in the getAvailableCommandLists. It is ok in terms of mutex locks now because unnecessary locks were removed from retain/release functions in b545c60
againull
changed the title
2 participants
Resetting command lists only in sycnhronization points caused
performance regression because we reuse less command lists and
new command lists are getting created more often which adds
performance overhead.
Return the old behavior back: reset signalled command lists
each time before requesting a command list to submit a command.