[NFC][SYCL][Reduction] Minor refactoring #6318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently, different versions do it differently...
v-klochkov
reviewed
Jun 17, 2022
| size_t OneElemSize = | ||
| IsTreeReduction ? sizeof(typename Reduction::result_type) : 0; | ||
| uint32_t NumConcurrentWorkGroups = | ||
| #ifdef __SYCL_REDUCTION_NUM_CONCURRENT_WORKGROUPS |
Contributor
There was a problem hiding this comment.
Why did you remove this macro read here?
Moving it to reduction.cpp is not the same as having it here.
The idea of this macro was to let user (and SYCL developers) experiment with it during compilation of the test/bench.
clang++ -fsycl my_bench.cpp -D__SYCL_REDUCTION_NUM_CONCURRENT_WORKGROUPS=16
Moving it to reduction.cpp means that variable would be ignored during my_bench.cpp compilation. Changing that var would require rebuild of libsycl.so
v-klochkov
approved these changes
Jun 17, 2022
Contributor
Author
|
@intel/llvm-gatekeepers , PR is ready for the merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.