Skip to content

[SYCL] Remove runtime library calls to OpenCL #6321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pvchupin merged 2 commits into from
Jun 18, 2022
Merged

[SYCL] Remove runtime library calls to OpenCL #6321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc89ffe
[SYCL] Remove runtime library calls to OpenCL
steffenlarsen Jun 17, 2022
f645b6d
Remove OpenCL ICD from linked libraries
steffenlarsen Jun 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions sycl/source/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ function(add_sycl_rt_library LIB_NAME)
${CMAKE_CURRENT_SOURCE_DIR}
"${sycl_inc_dir}"
)
#TODO: Remove dependency on icd loader and opencl headers.
#TODO: Remove dependency on opencl headers.
target_link_libraries(${LIB_OBJ_NAME}
PRIVATE OpenCL-Headers
)
Expand All @@ -95,7 +95,6 @@ function(add_sycl_rt_library LIB_NAME)

target_link_libraries(${LIB_NAME}
PRIVATE
OpenCL-ICD
${CMAKE_DL_LIBS}
${CMAKE_THREAD_LIBS_INIT}
)
Expand Down
2 changes: 1 addition & 1 deletion sycl/source/device.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ device::device(cl_device_id DeviceId) {
auto Platform =
detail::platform_impl::getPlatformFromPiDevice(Device, Plugin);
impl = Platform->getOrMakeDeviceImpl(Device, Platform);
clRetainDevice(DeviceId);
Plugin.call<detail::PiApiKind::piDeviceRetain>(impl->getHandleRef());
}

device::device(const device_selector &deviceSelector) {
Expand Down
3 changes: 2 additions & 1 deletion sycl/source/program.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,8 @@ program::program(const context &context, cl_program clProgram)
detail::pi::cast<pi_native_handle>(clProgram))) {
// The implementation constructor takes ownership of the native handle so we
// must retain it in order to adhere to SYCL 1.2.1 spec (Rev6, section 4.3.1.)
clRetainProgram(clProgram);
impl->getPlugin().call<detail::PiApiKind::piProgramRetain>(
impl->getHandleRef());
}

backend program::get_backend() const noexcept { return getImplBackend(impl); }
Expand Down