[SYCL] Removes more uses of OpenCL header definitions #6328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds various PI definitions and replaces some uses of OpenCL header definitions from the SYCL runtime library. To further isolate the remaining uses of the OpenCL headers, the includes of cl.h are moved from common.hpp to the dependend files. Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
steffenlarsen
added a commit
to steffenlarsen/llvm-test-suite
that referenced
this pull request
Jun 20, 2022
intel/llvm#6328 changes error reporting to use PI error enumerator names rather than OpenCL ones. Some of the test-suite tests rely on the OpenCL names being reported however, so this commit changes these tests to use the PI equivalents instead. Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Contributor
Author
|
/verify with intel/llvm-test-suite#1061 |
bader
reviewed
Jun 21, 2022
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
bader
approved these changes
Jun 21, 2022
smaslov-intel
approved these changes
Jun 21, 2022
Contributor
Author
|
/verify with intel/llvm-test-suite#1061 |
pvchupin
pushed a commit
to intel/llvm-test-suite
that referenced
this pull request
Jun 22, 2022
intel/llvm#6328 changes error reporting to use PI error enumerator names rather than OpenCL ones. Some of the test-suite tests rely on the OpenCL names being reported however, so this commit changes these tests to use the PI equivalents instead. Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
intel#6328 changes error reporting to use PI error enumerator names rather than OpenCL ones. Some of the test-suite tests rely on the OpenCL names being reported however, so this commit changes these tests to use the PI equivalents instead. Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds various PI definitions and replaces some uses of OpenCL header definitions from the SYCL runtime library.
To further isolate the remaining uses of the OpenCL headers, the includes of cl.h are moved from common.hpp to the dependend files.