[LIBCLC] Set charSize when calling __assertfail #6370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/verify with intel/llvm-test-suite#1070 |
|
PR title: Sat -> Set? |
Yeap, also just noticed conflicts in llvm-test-suite, will fix now. |
jchlanda
force-pushed
the
jakub/nvptx_assert
branch
from
91f772d to
5700e9f
Compare
jchlanda
changed the title
|
|
||
| _CLC_DECL void __assert_fail(const char *expr, const char *file, | ||
| unsigned int line, const char *func) { | ||
| __assertfail(expr, file, line, func); | ||
| __assertfail(expr, file, line, func, 1); |
There was a problem hiding this comment.
Very minor and not that I would ever expect them to differ, but should this be
Suggested change
| __assertfail(expr, file, line, func, 1); | |
| __assertfail(expr, file, line, func, sizeof(char)); |
for good measure?
There was a problem hiding this comment.
Hi @steffenlarsen, sorry was off last couple of days, I would normally agree, but in the PTX interoperability doc, they make an explicit point:
The only supported character size is 1
This was referenced Jun 28, 2022
steffenlarsen
approved these changes
Jun 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The missing parameter was causing the incorrect formatting of the assert messages.