[ESIMD] Fix potential accesses on nullptr reported by static verifier #6383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v-klochkov
force-pushed
the
esimd_verification_errors
branch
from
73c82d5 to
6ab6c14
Compare
Some places in LowerESIMD pass had assert statements preventing from access data referenced by nullptr. Those places were reported by static verfier for RELEASE build because 'assert' is NOP there. The fix calls llvm::report_fatal_error if the condition is not met. Also, the fix adds a missing copyright comment section to one of files created reacently. Signed-off-by: Vyacheslav N Klochkov <vyacheslav.n.klochkov@intel.com>
kychendev
approved these changes
Jul 1, 2022
smaslov-intel
approved these changes
Jul 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some places in LowerESIMD pass had assert statements preventing from
access data referenced by nullptr. Those places were reported by
static verfier for RELEASE build because 'assert' is NOP there.
The fix calls llvm::report_fatal_error if the condition is not met.
Also, the fix adds a missing copyright comment section to one of files
created reacently.
Signed-off-by: Vyacheslav N Klochkov vyacheslav.n.klochkov@intel.com