[SYCL] Enable FTZ operations for CUDA/PTX backend via -fcuda-flush-denormals-to-zero #6411
Conversation
| case options::OPT_fgpu_flush_denormals_to_zero: | ||
| DenormalFPMath = llvm::DenormalMode::getPositiveZero(); | ||
| DenormalFP32Math = llvm::DenormalMode::getPositiveZero(); | ||
| break; |
There was a problem hiding this comment.
Could you add a driver test verifying the expect values when the options are set?
There was a problem hiding this comment.
@mdtoguchi Do you prefer a separate test for this, or should I add it to the clang/test/Driver/fp-model.c?
|
Please add a CodeGen test for this. |
|
@andykaylor, FYI. |
|
@premanandrao Please review this PR. |
@premanandrao is OOO next week . I see he has reviewed the patch earlier and requested a CodeGen test which hasn't been added yet |
|
@elizabethandrews @againull This is my bad. I'll add a test case next week. |
|
@elizabethandrews @againull I just added a CodeGen test case. |
premanandrao
left a comment
premanandrao
left a comment
There was a problem hiding this comment.
FE changes look good to me.
|
@intel/llvm-gatekeepers, this looks ready to go. |
8 participants
Gives a small performance benefit for Gromacs on NVidia targets