-
Notifications
You must be signed in to change notification settings - Fork 801
[SYCL][ABI-break] Remove kernel::get_work_group_info #6414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Sweet! Since it is an ABI break we should increment the library engineering version as described in ABIPolicyGuide. Also, the corresponding symbol should be removed from sycl/test/abi/sycl_symbols_windows.dump. |
|
/verify with intel/llvm-test-suite#1082 |
Signed-off-by: Rauf, Rana <rana.rauf@intel.com>
6aed686 to
d364cb1
Compare
Signed-off-by: Rauf, Rana <rana.rauf@intel.com>
|
/verify with intel/llvm-test-suite#1082 |
1 similar comment
|
/verify with intel/llvm-test-suite#1082 |
|
/verify with intel/llvm-test-suite#1082 |
1 similar comment
|
/verify with intel/llvm-test-suite#1082 |
|
This is now passing the tests. The pass with the matching test PR (1082) is Jenkins/llvm-test-suite. |
|
/verify with intel/llvm-test-suite#1082 |
cperkinsintel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…into work_group_info_issue
|
/verify with intel/llvm-test-suite#1082 |
|
/verify with intel/llvm-test-suite#1082 |
|
@raaiq1, @againull, @aelovikov-intel, could you update SYCL-CTS the same was as you updated llvm-test-suite, please? CI logs: https://github.com/intel/llvm/runs/7446699040?check_suite_focus=true |
[SYCL][ABI-break] Remove kernel::get_work_group_info (intel#6414)
@raaiq1 kindly agreed to take a look at this. |
Uh oh!
There was an error while loading. Please reload this page.