Skip to content

Conversation

@raaiq1
Copy link
Contributor

@raaiq1 raaiq1 commented Jul 7, 2022

  • Removed template definitions of kernel::get_work_group_info.
  • Deleted 'sycl/test/warnings/kernel_wg_info_deprecation.cpp' : which tests for deprecated feature
  • Removed a unittest call to such feature and updated linux symbols

@raaiq1 raaiq1 requested review from a team as code owners July 7, 2022 20:54
@raaiq1 raaiq1 requested a review from smaslov-intel July 7, 2022 20:54
@steffenlarsen
Copy link
Contributor

Sweet! Since it is an ABI break we should increment the library engineering version as described in ABIPolicyGuide.

Also, the corresponding symbol should be removed from sycl/test/abi/sycl_symbols_windows.dump.

@bader bader changed the title [SYCL] [ABI-break] Removed kernel::get_work_group_info [SYCL][ABI-break] Remove kernel::get_work_group_info Jul 8, 2022
@raaiq1
Copy link
Contributor Author

raaiq1 commented Jul 13, 2022

/verify with intel/llvm-test-suite#1082

Signed-off-by: Rauf, Rana <rana.rauf@intel.com>
@raaiq1 raaiq1 force-pushed the work_group_info_issue branch from 6aed686 to d364cb1 Compare July 13, 2022 21:10
@raaiq1
Copy link
Contributor Author

raaiq1 commented Jul 14, 2022

/verify with intel/llvm-test-suite#1082

1 similar comment
@cperkinsintel
Copy link
Contributor

/verify with intel/llvm-test-suite#1082

@raaiq1
Copy link
Contributor Author

raaiq1 commented Jul 15, 2022

/verify with intel/llvm-test-suite#1082

1 similar comment
@cperkinsintel
Copy link
Contributor

/verify with intel/llvm-test-suite#1082

@cperkinsintel
Copy link
Contributor

This is now passing the tests. The pass with the matching test PR (1082) is Jenkins/llvm-test-suite.

@cperkinsintel
Copy link
Contributor

/verify with intel/llvm-test-suite#1082

Copy link
Contributor

@cperkinsintel cperkinsintel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cperkinsintel
Copy link
Contributor

/verify with intel/llvm-test-suite#1082

@cperkinsintel
Copy link
Contributor

/verify with intel/llvm-test-suite#1082

@againull againull merged commit 9488347 into intel:sycl Jul 20, 2022
raaiq1 added a commit to raaiq1/llvm that referenced this pull request Jul 21, 2022
[SYCL][ABI-break] Remove kernel::get_work_group_info (intel#6414)
@raaiq1 raaiq1 deleted the work_group_info_issue branch July 22, 2022 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants