[Driver][SYCL] Properly tag temporary list file for archive unbundling #6470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When unbundling archives, we were not properly tagging the type of file being generated as a temporary list file. This was causing the cleanup to miss the generated unbundled objects from the unbundle step.
Contributor
Author
|
@qichaogu, can you review on behalf of driver? |
asudarsa
reviewed
Jul 25, 2022
qichaogu
approved these changes
Jul 26, 2022
Contributor
Author
|
@bader, could you take a look? other approving driver reviewers are currently out. |
Contributor
I see two approves already, so I think it's enough to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When unbundling archives, we were not properly tagging the type of file
being generated as a temporary list file. This was causing the cleanup
to miss the generated unbundled objects from the unbundle step.