-
Notifications
You must be signed in to change notification settings - Fork 768
[SYCL][CUDA] Enable CXX standard library funcs for CUDA backend #6482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…der. This is because the SYCLToolChain is only used for SPIR-V backends
smanna12
reviewed
Jul 27, 2022
Co-authored-by: smanna12 <soumi.manna@intel.com>
steffenlarsen
previously approved these changes
Aug 11, 2022
ping @jinge90 |
Hi, @hdelan
Thanks very much. |
Thanks for response.
Let me know if you have any other questions |
OK, thanks for the clarification. |
jinge90
previously approved these changes
Aug 18, 2022
steffenlarsen
approved these changes
Aug 26, 2022
mdtoguchi
approved these changes
Aug 30, 2022
jinge90
approved these changes
Sep 2, 2022
steffenlarsen
pushed a commit
to intel/llvm-test-suite
that referenced
this pull request
Sep 2, 2022
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows CXX stdlib funcs to be used for NVPTX backend.
See #6379
llvm-test-suite test: intel/llvm-test-suite#1112
It also adds the compiler flag
"-fbundle-no-offload-arch"
, which allows device code bundles to omit arch information, meaning a bundle with the tagsycl-nvptx64-nvidia-cuda-sm_50
can be bundled with the tagsycl-nvptx64-nvidia-cuda
when the flag is enabled. This allows for generic bc bundles for a given backend.I have not moved the NVPTX complex implementation to libdevice. Let me know if I should do so.
The behaviour of
IsMathErrnoDefault()
now changes so that-fmath-errno
is enabled by default for the CUDA toolchain. This allows libdevice funcs to be used by a similar exploit that the SYCL toolchain uses. If necessary this could be reset once the upstream discussion on NVPTX codegen forllvm.sin
and other llvm builtins has been resolved and implemented. See https://discourse.llvm.org/t/nvptx-codegen-for-llvm-sin-and-friends/58170/11?u=jdoerfertcc @Naghasan @AerialMantis @steffenlarsen @bader @jdoerfert