[SYCL][NFC] Remove or ignore unused parameters and captures #6564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes an unused capture in the PI L0 backend and ignores two parameters in MemoryManager::allocateHostMemory. Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
steffenlarsen
commented
Aug 11, 2022
| bool HostPtrReadOnly, size_t Size, | ||
| const sycl::property_list &) { | ||
| std::ignore = HostPtrReadOnly; | ||
| std::ignore = Size; |
Contributor
Author
There was a problem hiding this comment.
Alternatively we remove the arguments from the function entirely.
smaslov-intel
approved these changes
Aug 11, 2022
Contributor
Author
|
Failing CUDA tests (Assert/assert_in_simultaneous_kernels.cpp & Assert/assert_in_simultaneously_multiple_tus.cpp) are known sporadic failures and are unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes an unused capture in the PI L0 backend and ignores two parameters in MemoryManager::allocateHostMemory.