[SYCL] Move accessor_impl to source directory #6698
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moving impl part of host accessor implementation to avoid exposing implementation details in the headers. This allows for more changes in accessor without breaking ABI. Also updated the gdb pretty-printer since it was relying on the impl details which are not available for gdb(unless libsycl.so is built with debug symbols) anymore. Instead of accessing members of impl directly gdb printers now accessing helper methods. To prevent compiler discarding these methods there are dummy references which are active when NDEBUG is not defined.
Contributor
Author
|
@steffenlarsen Could you please take a look? |
barisaktemur
previously approved these changes
Sep 12, 2022
barisaktemur
left a comment
barisaktemur
left a comment
There was a problem hiding this comment.
Besides the code-reuse comment I made previously and the commit message suggestion below, the sycl/gdb/libsycl.so-gdb.py changes look fine to me.
romanovvlad
dismissed stale reviews from barisaktemur, steffenlarsen, and v-klochkov
via
ec265c4
romanovvlad
requested review from
barisaktemur,
steffenlarsen and
v-klochkov
steffenlarsen
approved these changes
Sep 12, 2022
v-klochkov
approved these changes
Sep 12, 2022
Contributor
Author
|
/verify with intel/llvm-test-suite#1252 |
Contributor
Author
|
Trying to fix unrelated fail here: intel/llvm-test-suite#1254 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving impl part of host accessor implementation to avoid exposing
implementation details in the headers. This allows for more changes
in accessor without breaking ABI.
Also updated the gdb xmethods since it was relying on the
impl details which are not available for gdb(unless libsycl.so is
built with debug symbols) anymore. Instead of accessing members of
impl directly gdb printers now accessing helper methods. To prevent
compiler discarding these methods there are dummy references which
are active when NDEBUG is not defined.