Skip to content

[CI][NFC] Fixed GFX driver update PR #6723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pvchupin merged 2 commits into from
Sep 7, 2022
Merged

[CI][NFC] Fixed GFX driver update PR #6723

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd18fc7
[CI][NFC] Fixed GFX driver update PR
apstasen Sep 7, 2022
a165426
Moved ${{ github.sha }} into input param default.
apstasen Sep 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions .github/workflows/sycl_gen_test_matrix.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,11 @@ on:
type: string
required: false
default: ${{ github.run_id }}-${{ github.run_attempt }}
ref:
description: "Commit to use for checkout or github.sha by default"
type: string
required: false
Copy link
Contributor

@pvchupin pvchupin Sep 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we have github.sha as default here? and use just inputs.ref below?

Copy link
Contributor Author

@apstasen apstasen Sep 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure you can use variable like ${{github.sha}} as default value here. Only constants are possible I think.

Copy link
Contributor Author

@apstasen apstasen Sep 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you are right and we can use variables in this place after Azure/actions#2 fix

Copy link
Contributor Author

@apstasen apstasen Sep 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P.S. Also noticed I used it before in uniq input param just fine :)

default: ${{ github.sha }}
outputs:
lts_matrix:
description: "Generated Matrix"
Expand All @@ -42,11 +47,11 @@ jobs:
- name: Download scripts and configs
shell: bash
run: |
wget raw.githubusercontent.com/intel/llvm/${{ github.sha }}/devops/scripts/generate_test_matrix.js
wget raw.githubusercontent.com/intel/llvm/${{ github.sha }}/devops/test_configs.json
wget raw.githubusercontent.com/intel/llvm/${{ inputs.ref }}/devops/scripts/generate_test_matrix.js
wget raw.githubusercontent.com/intel/llvm/${{ inputs.ref }}/devops/test_configs.json
wget raw.githubusercontent.com/intel/llvm/sycl/devops/dependencies.json
mv dependencies.json dependencies.sycl.json
wget raw.githubusercontent.com/intel/llvm/${{ github.sha }}/devops/dependencies.json
wget raw.githubusercontent.com/intel/llvm/${{ inputs.ref }}/devops/dependencies.json
- id: work
uses: actions/github-script@v6
name: Generate matrix
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/sycl_precommit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ jobs:
name: Generate Test Matrix
uses: ./.github/workflows/sycl_gen_test_matrix.yml
with:
ref: ${{ github.event.pull_request.head.sha }}
lts_config: "hip_amdgpu;ocl_x64;ocl_gen9;l0_gen9;esimd_emu;cuda"

linux_default:
Expand Down