[SYCL][ABI-Break] Implement property interface for local_accessor & #6737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Is there a test being added for this? |
Contributor
Author
|
@aelovikov-intel not yet and I'm not sure if we can do this, as these classes don't have any properties yet |
Contributor
Author
|
This is an additional patch for #6614 |
aelovikov-intel
previously approved these changes
Sep 8, 2022
Contributor
aelovikov-intel
left a comment
aelovikov-intel
left a comment
There was a problem hiding this comment.
The change looks ok by itself but I lack experience to tell if something is missing or reason about the bigger picture. Please consider asking other people if you want to have a reviewer with deeper knowledge in the area :)
Contributor
|
Also, can you increment the dev version in sycl/CMakeLists.txt ? |
Contributor
Author
|
@steffenlarsen @AlexeySachkov could you take a look please? |
Contributor
Author
|
Re-trigger test |
Contributor
Author
|
I believe these fails are unrelated, since it was okay for the first run. |
Contributor
Author
|
Re-trigger tests |
Contributor
Author
|
Re-trigger (sorry for spam, I believe this is the last attempt) |
steffenlarsen
approved these changes
Sep 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
usm_allocator