[SYCL][ABI-Break] Promote binary image properties and make it extendible #6762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously adding parsing of new properties from sycl-post-link in the runtime required repeat initialization of the corresponding property ranges as making them members would break ABI. This commit moves the members into a vector which is initialized by the constructors inside the source of the runtime library. Doing this ensures that the corresponding vector will have at least as much space as the headers on the user-side needs and exactly the amount that the runtime library expects, preventing out-of-bounds accesses while allowing future extendibility without breaking ABI. Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Contributor
Author
|
Per offline discussion with @romanovvlad, a better solution is to move this to sources. This is done in #6768. Closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously adding parsing of new properties from sycl-post-link in the runtime required repeat initialization of the corresponding property ranges as making them members would break ABI.
This commit moves the members into a vector which is initialized by the constructors inside the source of the runtime library. Doing this ensures that the corresponding vector will have at least as much space as the headers on the user-side needs and exactly the amount that the runtime library expects, preventing out-of-bounds accesses while allowing future extendibility without breaking ABI.