[SYCL] Update sub-group reduce/scan syntax #688
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aligns the sub-group implementation with the extension doc: - Enables reduce and scan to take functors as arguments - Adds OpenCL-like reduce(x, op) overload to extension doc Also clarifies interpretation of init values in documentation. Signed-off-by: John Pennycook <john.pennycook@intel.com>
Simplifies usage to reduce(x, plus<>()) Signed-off-by: John Pennycook <john.pennycook@intel.com>
Test all variants of reduce: - With and without init - With op<T>() and op<void>() Signed-off-by: John Pennycook <john.pennycook@intel.com>
Test all variants of scan: - Inclusive and exclusive - With and without init - With op<T>() and op<void>() Signed-off-by: John Pennycook <john.pennycook@intel.com>
Avoids exporting is_vec and calc. Signed-off-by: John Pennycook <john.pennycook@intel.com>
vladimirlaz
previously approved these changes
Oct 2, 2019
bader
reviewed
Oct 2, 2019
Avoid duplicated code in sub_group.hpp and sub_group_host.hpp. Signed-off-by: John Pennycook <john.pennycook@intel.com>
bader
approved these changes
Oct 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aligns the sub-group implementation with the extension doc:
Also clarifies interpretation of init values in documentation.
Signed-off-by: John Pennycook john.pennycook@intel.com