Skip to content

[SYCL][Reduction] Prefer fast group reduce over fast atomics #6890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
steffenlarsen merged 1 commit into from
Sep 29, 2022
Merged

[SYCL][Reduction] Prefer fast group reduce over fast atomics #6890

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions sycl/include/sycl/reduction.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1133,12 +1133,12 @@ bool reduCGFuncForRange(handler &CGH, KernelType KernelFunc,
size_t NDRItems = NWorkGroups * WGSize;
nd_range<1> NDRange{range<1>{NDRItems}, range<1>{WGSize}};

if constexpr (Reduction::has_fast_atomics)
return reduCGFuncForRangeFastAtomics<KernelName>(CGH, KernelFunc, Range,
NDRange, Redu);
else if constexpr (Reduction::has_fast_reduce)
if constexpr (Reduction::has_fast_reduce)
return reduCGFuncForRangeFastReduce<KernelName>(CGH, KernelFunc, Range,
NDRange, Redu);
else if constexpr (Reduction::has_fast_atomics)
return reduCGFuncForRangeFastAtomics<KernelName>(CGH, KernelFunc, Range,
NDRange, Redu);
else
return reduCGFuncForRangeBasic<KernelName>(CGH, KernelFunc, Range, NDRange,
Redu);
Expand Down