-
Notifications
You must be signed in to change notification settings - Fork 765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL][libdevice] Add bfloat16 imf utils. #6999
Conversation
Signed-off-by: jinge90 <ge.jin@intel.com>
Signed-off-by: jinge90 <ge.jin@intel.com>
Signed-off-by: jinge90 <ge.jin@intel.com>
Signed-off-by: jinge90 <ge.jin@intel.com>
Signed-off-by: jinge90 <ge.jin@intel.com>
Signed-off-by: jinge90 <ge.jin@intel.com>
Hi, @zettai-reido and @akolesov-intel Thanks very much. |
Signed-off-by: jinge90 <ge.jin@intel.com>
The draft looks good for me so far, thank you! |
Signed-off-by: jinge90 <ge.jin@intel.com>
Signed-off-by: jinge90 <ge.jin@intel.com>
Hi, @intel/dpcpp-clang-driver-reviewers , @intel/dpcpp-tools-reviewers , @intel/llvm-reviewers-runtime Thanks very much. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Runtime changes LGTM!
/verify with intel/llvm-test-suite#1364 |
Hi, @intel/dpcpp-tools-reviewers Thanks very much. |
Hi, @asudarsa Thanks very much. |
Hi, @pvchupin @intel/dpcpp-tools-reviewers Thanks very much. |
Hi, @pvchupin and @intel/dpcpp-tools-reviewers Thanks very much. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok to me. There are some empty .o and .obj files in test/Driver directory. Can you please check and comment if they need to be removed?
Thanks
Hi, @asudarsa Thanks very much for the review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for clarification. LGTM.
Hi, @pvchupin |
Signed-off-by: jinge90 ge.jin@intel.com
This PR adds a new SYCL device library for bf16 type. Some bf16 util functions will be supported via this new added device library. This patch includes fundamental changes to add this bf16 device library and provide necessary conversion functions between fp32 and bf16 types, some trival math functions are also provided.
Currently, we use fp32 to emulate all those fb16 functions, so the bf16 sycl device library doesn't need native bf16 support.