[SYCL] CFE fixes for sycl_ext_oneapi_kernel_properties #7016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes the following changes to the Clang frontend in
preparation for the initial implementation of the
sycl_ext_oneapi_kernel_properties extension:
* Fixed an issue preventing initializer lists of characters to be used
as strings in add_ir_{attributes|annotations}_* attributes.
* The add_ir_attributes_function will now be copied onto the generated
kernel declaration from the recognized kernel_* functions.
* Added a warning diagnostic for when a kernel has both an
add_ir_attributes_function (with values) and one or more potentially
conflicting SYCL attributes.
This is split from intel#6941.
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
This was referenced Oct 11, 2022
Fznamznon
reviewed
Oct 13, 2022
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Fznamznon
approved these changes
Oct 13, 2022
elizabethandrews
approved these changes
Oct 13, 2022
Contributor
elizabethandrews
left a comment
elizabethandrews
left a comment
There was a problem hiding this comment.
LGTM other than wording nit
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
elizabethandrews
approved these changes
Oct 13, 2022
smanna12
approved these changes
Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes the following changes to the Clang frontend in preparation for the initial implementation of the
sycl_ext_oneapi_kernel_properties extension:
This is split from #6941.