Skip to content

[NFC][Reduction] Remove C++17 guards #7181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pvchupin merged 1 commit into from
Oct 26, 2022
Merged

[NFC][Reduction] Remove C++17 guards #7181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions sycl/include/sycl/handler.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1756,10 +1756,6 @@ class __SYCL_EXPORT handler {
KernelFunc);
}

// "if constexpr" simplifies implementation/increases readability in comparison
// with SFINAE-based approach.
#if __cplusplus >= 201703L

/// Defines and invokes a SYCL kernel function for the specified nd_range.
///
/// The SYCL kernel function is defined as a lambda function or a named
Expand Down Expand Up @@ -1982,7 +1978,6 @@ class __SYCL_EXPORT handler {
});
} // end while (NWorkItems > 1)
}
#endif // __cplusplus >= 201703L

/// Hierarchical kernel invocation method of a kernel defined as a lambda
/// encoding the body of each work-group to launch.
Expand Down
15 changes: 0 additions & 15 deletions sycl/include/sycl/reduction.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,16 +49,6 @@ template <typename T> struct AreAllButLastReductions<T> {
static constexpr bool value = !IsReduction<T>::value;
};
} // namespace detail
} // __SYCL_INLINE_VER_NAMESPACE(_V1)
} // namespace sycl

#if __cplusplus >= 201703L
// Entire feature is dependent on C++17. We still have to make the trait above
// available as queue shortcuts use them unconditionally, including on
// non-reduction path.
namespace sycl {
__SYCL_INLINE_VER_NAMESPACE(_V1) {


/// Class that is used to represent objects that are passed to user's lambda
/// functions and representing users' reduction variable.
Expand Down Expand Up @@ -2477,7 +2467,6 @@ auto reduction(T *Var, const T &Identity, BinaryOperation Combiner,
InitializeToIdentity);
}

#if __cplusplus >= 201703L
/// Constructs a reduction object using the reduction variable referenced by
/// the given sycl::span \p Span, reduction operation \p Combiner, and
/// optional reduction properties.
Expand Down Expand Up @@ -2524,9 +2513,5 @@ auto reduction(span<T, Extent> Span, const T &Identity,
return detail::make_reduction<BinaryOperation, 1, Extent>(
Span.data(), Identity, Combiner, InitializeToIdentity);
}
#endif

} // __SYCL_INLINE_VER_NAMESPACE(_V1)
} // namespace sycl

#endif // __cplusplus >= 201703L