[SYCL][Docs] Move sycl_ext_oneapi_kernel_properties to experimental #7190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit moves the sycl_ext_oneapi_kernel_properties extension from proposal to experimental. As part of the move, the extension is transitioned to the new extension template. Additionally it adds a note about the current order limitation of `SYCL_EXT_ONEAPI_FUNCTION_PROPERTY` and `SYCL_EXTERNAL` in the current implementation. Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Contributor
Author
|
This is in draft until the extension rest of the implementation is merged. |
Pennycook
requested changes
Oct 26, 2022
Contributor
Pennycook
left a comment
Pennycook
left a comment
There was a problem hiding this comment.
Aside from the copyright date, LGTM.
sycl/doc/extensions/experimental/sycl_ext_oneapi_kernel_properties.asciidoc
Outdated
Show resolved
Hide resolved
…ties.asciidoc Co-authored-by: John Pennycook <john.pennycook@intel.com>
gmlueck
reviewed
Nov 7, 2022
sycl/doc/extensions/experimental/sycl_ext_oneapi_kernel_properties.asciidoc
Show resolved
Hide resolved
sycl/doc/extensions/experimental/sycl_ext_oneapi_kernel_properties.asciidoc
Outdated
Show resolved
Hide resolved
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
gmlueck
reviewed
Nov 7, 2022
| This is an experimental extension specification, intended to provide early | ||
| access to features and gather community feedback. Interfaces defined in this | ||
| specification are implemented in DPC++, but they are not finalized and may | ||
| change incompatibly in future versions of DPC++ without prior notice. |
Contributor
There was a problem hiding this comment.
The DPC++ doesn't seem to render correctly in HTML. I think is is because the + are being interpreted by Asciidoctor as an inline passthrough. I think you will instead need to define the {dpcpp} macro at the top of the file.
Contributor
Author
There was a problem hiding this comment.
I don't know how I missed the template defined in the template, but I have added it. Looks to be rendering correctly now.
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Contributor
Author
|
This is ready for review. |
dm-vodopyanov
approved these changes
Nov 10, 2022
Pennycook
approved these changes
Nov 10, 2022
Contributor
Author
|
Failures unrelated:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit moves the sycl_ext_oneapi_kernel_properties extension from proposal to experimental. As part of the move, the extension is transitioned to the new extension template.
Additionally it adds a note about the current order limitation of
SYCL_EXT_ONEAPI_FUNCTION_PROPERTYandSYCL_EXTERNALin the current implementation.