[SYCL][DOC] Initial commit for queue priority extension#7228
[SYCL][DOC] Initial commit for queue priority extension#7228jbrodman wants to merge 4 commits intointel:syclfrom
Conversation
Signed-off-by: James Brodman <james.brodman@intel.com>
sycl/doc/extensions/proposed/sycl_ext_oneapi_queue_priority.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/proposed/sycl_ext_oneapi_queue_priority.asciidoc
Outdated
Show resolved
Hide resolved
…ciidoc Co-authored-by: John Pennycook <john.pennycook@intel.com>
Signed-off-by: James Brodman <james.brodman@intel.com>
Signed-off-by: James Brodman <james.brodman@intel.com>
|
|
||
| | `sycl::ext::oneapi::info::queue::priority_range` | ||
| | Returns a `std::array<int,2>` that represents the `{leastPriority,greatestPriority}` | ||
| for this queue. Lower numbers imply greater priorities. The default priority has value `0`. |
There was a problem hiding this comment.
Lower numbers imply greater priorities
I think this will be confusing. Can we flip this, so that higher numbers mean higher priority? This would match the Posix sched_get_priority_max / sched_get_priority_min APIs, and it would match the Windows SetThreadPriority API. In all of those, higher numbers mean higher priority,
| | `sycl::ext::oneapi::property::queue::priority(int priority=0)` | ||
| | Specifies that the queue should be constructed with the specified `priority`. | ||
| Commands executed by this queue may take priority over commands with lower priority | ||
| on this queue's device. The default priority has value `0`. If the user specifies |
There was a problem hiding this comment.
I think this should not have a default value. Users should be required to specify a priority. There is no reason to use the priority property if you want to get default behavior If you want default behavior, you don't need the property at all. Code that uses property wants some non-default behavior, so we should require that code to specify which priority they want.
Otherwise, I can imagine someone writing code like this, thinking that they created a queue with high priority:
sycl::queue q{priority{}};
| == Notice | ||
|
|
||
| [%hardbreaks] | ||
| Copyright (C) 2022-2023 Intel Corporation. All rights reserved. |
There was a problem hiding this comment.
| Copyright (C) 2022-2023 Intel Corporation. All rights reserved. | |
| Copyright (C) 2022 Intel Corporation. All rights reserved. |
We just use the first date of publication now.
|
|
||
| == Dependencies | ||
|
|
||
| This extension is written against the SYCL 2020 revision 6 specification. All |
There was a problem hiding this comment.
| This extension is written against the SYCL 2020 revision 6 specification. All | |
| This extension is written against the SYCL 2020 revision 8 specification. All |
|
This pull request is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be automatically closed in 30 days. |
|
This pull request was closed because it has been stalled for 30 days with no activity. |
3 participants
Signed-off-by: James Brodman james.brodman@intel.com