Skip to content

[SYCL][PI][L0] Uplift L0 Loader from 1.4.1 to 1.8.8 #7381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
againull merged 1 commit into from
Nov 15, 2022
Merged

[SYCL][PI][L0] Uplift L0 Loader from 1.4.1 to 1.8.8 #7381

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sycl/plugins/level_zero/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ if (NOT DEFINED LEVEL_ZERO_LIBRARY OR NOT DEFINED LEVEL_ZERO_INCLUDE_DIR)
if (WIN32)
set(LEVEL_ZERO_LOADER_SOURCE_VERSION v1.2.3)
else()
set(LEVEL_ZERO_LOADER_SOURCE_VERSION v1.4.1)
set(LEVEL_ZERO_LOADER_SOURCE_VERSION v1.8.8)
endif()
Comment on lines 24 to 28
Copy link
Contributor

@bader bader Nov 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we use different version on Windows and non-Windows platforms?

Copy link
Contributor

@smaslov-intel smaslov-intel Nov 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know the answer to that question, but have another one: why did we need to change the Linux version but not the Windows version?

Copy link
Contributor

@bader bader Nov 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC, there was some problem with using newer loader + Windows GPU driver combination. I wonder if this problem still exists, or we can switch back to using the same loader version for all platforms.
@yanfeng3721, could you test v1.8.8 on Windows, please?


#TODO: Replace ExternalProject with FetchContent for better maintainance and
Expand Down