[NFC][SYCL] Remove checks for C++17 #7687
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has been the minimally supported version for some time and we have a static_assert to guard for it. No need to conditionally disable parts of the codebase.
aelovikov-intel
commented
Dec 7, 2022
| #endif | ||
|
|
||
| #ifndef __SYCL_DEPRECATED | ||
| // The deprecated attribute is not supported in some situations(e.g. namespace) |
Contributor
Author
There was a problem hiding this comment.
I'm not touching lines 60 and 76 because those should be addressed by eliminating the defines and updating the code base to use the C++17 features without wrapping them behind the macros.
Contributor
Author
Known - #7634. |
cperkinsintel
approved these changes
Dec 8, 2022
Contributor
cperkinsintel
left a comment
cperkinsintel
left a comment
There was a problem hiding this comment.
Sweet! LGTM.
Let the if constexpr flow like water!
Contributor
Author
|
@intel/llvm-gatekeepers , this PR is ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been the minimally supported version for some time and we have a static_assert to guard for it. No need to conditionally disable parts of the codebase.