-
Notifications
You must be signed in to change notification settings - Fork 769
[SYCL-MLIR] Handle accesses of structure of vector #7767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
sycl::detail::Boolean
sycl::detail::Boolean
Signed-off-by: Tsang, Whitney <whitney.tsang@intel.com>
d281604
to
5764fbb
Compare
I propose replacing this test with a non-SYCL one in the parent directory. Instead of using |
Signed-off-by: Tsang, Whitney <whitney.tsang@intel.com>
Signed-off-by: Tsang, Whitney <whitney.tsang@intel.com>
3ad9e27
to
0abdd0c
Compare
Signed-off-by: Tsang, Whitney <whitney.tsang@intel.com>
df81239
to
d56f38d
Compare
Signed-off-by: Tsang, Whitney <whitney.tsang@intel.com>
I created a generic test case, but it is still in sycl, as we need to test when default addrspace is different. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'd also change the commit message to make it more generic (not a particular |
sycl::detail::Boolean
Since #7706, we decided to not add types under
sycl::detail
namespace in SYCL dialect.So
sycl::detail::Boolean
is represented as llvm structure of vector type.Pointer of struct is represented as
llvm.ptr<struct<...>>
, instead ofmemref<?xstruct<...>>
.Accessing element of the struct uses
llvm.getelementptr
, which producesllvm.ptr
.If an element of the struct is
vector
, then pointer to it would bellvm.ptr<vector>
.Pointer of SYCL type is represented as
memref<?x!sycl...>
.Accessing element of the SYCL type uses
polygeist.subindex
, which producesmemref
.If an element of the SYCL type is
vector
, e.g.,!sycl.vec
, then pointer to it would bememref<vector>
.We need to modify some code that does vector handling, as
llvm.ptr<vector>
is possible.