[SYCL][NFCI] Move default optimization level configuration #7885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now the front-end compiler modifies default optimization level in SYCL device compilation mode (upstream clang uses O0, whereas DPC++ uses O2). As some of CodeGen module patches landed to upstream, this difference causes conflicts and regresions when we pull changes from the upstream to the `sycl` branch. Current optimization level configuration is modeled after OpenCL compiler, which is a JIT compiler, so it doesn't use clang Driver. For DPC++ compiler it's more reasonable to make this type of changes in the driver to avoid significant divergence in LIT tests.
Fznamznon
reviewed
Jan 2, 2023
Fznamznon
reviewed
Jan 3, 2023
Fznamznon
approved these changes
Jan 3, 2023
smanna12
approved these changes
Jan 3, 2023
premanandrao
approved these changes
Jan 4, 2023
elizabethandrews
approved these changes
Jan 4, 2023
Contributor
Author
|
@intel/dpcpp-clang-driver-reviewers, could you take a look, please? |
mdtoguchi
reviewed
Jan 4, 2023
Contributor
Author
|
Pre-commit failure on AMDGPU is an issue in the test that will be fixed with intel/llvm-test-suite#1487. |
whitneywhtsang
added a commit
to whitneywhtsang/llvm
that referenced
this pull request
Jan 7, 2023
…ntel#7885)" This reverts commit 102e154.
whitneywhtsang
added a commit
to whitneywhtsang/llvm
that referenced
this pull request
Jan 13, 2023
…ation (intel#7885)"" This reverts commit 2c2a529.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the front-end compiler modifies default optimization level in SYCL device compilation mode (upstream clang uses O0, whereas DPC++ uses O2). As some of CodeGen module patches landed to upstream, this difference causes conflicts and regresions when we pull changes from the upstream to the
syclbranch.Current optimization level configuration is modeled after OpenCL compiler, which is a JIT compiler, so it doesn't use clang Driver. For DPC++ compiler it's more reasonable to make this type of changes in the driver to avoid significant divergence in LIT tests.