Skip to content

[SYCL][CUDA][HIP] Implement piextUSMEnqueueMemcpy2D #7941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bader merged 18 commits into from
Jan 25, 2023
Merged

[SYCL][CUDA][HIP] Implement piextUSMEnqueueMemcpy2D #7941

bader merged 18 commits into from
Jan 25, 2023

Conversation

@abagusetty
Copy link
Contributor

@abagusetty abagusetty commented Jan 5, 2023

No description provided.

@abagusetty abagusetty requested review from a team as code owners January 5, 2023 21:24
@abagusetty abagusetty requested a review from romanovvlad January 5, 2023 21:24
@abagusetty abagusetty temporarily deployed to aws January 5, 2023 21:48 — with GitHub Actions Inactive
@abagusetty
Copy link
Contributor Author

abagusetty commented Jan 5, 2023

@steffenlarsen Would be great if you too can take a peek

@abagusetty abagusetty temporarily deployed to aws January 5, 2023 22:38 — with GitHub Actions Inactive
@steffenlarsen steffenlarsen self-requested a review January 6, 2023 09:04
steffenlarsen
steffenlarsen requested changes Jan 6, 2023
View reviewed changes
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of comments, but otherwise it looks good.

It may be the extension title being confusing, but this is not actually implementing all of sycl_ext_oneapi_memcpy2d but just the piextUSMEnqueueMemcpy2D side. Could you please change the title of this PR to reflect this?

@abagusetty abagusetty changed the title [SYCL][CUDA][HIP] Implement sycl_ext_oneapi_memcpy2d [SYCL][CUDA][HIP] Implement piextUSMEnqueueMemcpy2D Jan 6, 2023
@abagusetty abagusetty temporarily deployed to aws January 6, 2023 16:21 — with GitHub Actions Inactive
@abagusetty abagusetty temporarily deployed to aws January 6, 2023 16:27 — with GitHub Actions Inactive
@abagusetty abagusetty temporarily deployed to aws January 6, 2023 18:01 — with GitHub Actions Inactive
@abagusetty abagusetty temporarily deployed to aws January 6, 2023 18:35 — with GitHub Actions Inactive
@abagusetty abagusetty temporarily deployed to aws January 7, 2023 00:46 — with GitHub Actions Inactive
@abagusetty abagusetty temporarily deployed to aws January 7, 2023 01:47 — with GitHub Actions Inactive
@abagusetty abagusetty temporarily deployed to aws January 7, 2023 02:17 — with GitHub Actions Inactive
steffenlarsen
steffenlarsen approved these changes Jan 9, 2023
View reviewed changes
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks! 🚀

@bader
Copy link
Contributor

bader commented Jan 18, 2023

@abagusetty, please, fix test failures on CUDA.

@abagusetty abagusetty temporarily deployed to aws January 22, 2023 18:22 — with GitHub Actions Inactive
@abagusetty abagusetty temporarily deployed to aws January 23, 2023 00:28 — with GitHub Actions Inactive
@abagusetty abagusetty temporarily deployed to aws January 23, 2023 22:27 — with GitHub Actions Inactive
@abagusetty abagusetty temporarily deployed to aws January 23, 2023 23:28 — with GitHub Actions Inactive
@abagusetty abagusetty temporarily deployed to aws January 24, 2023 11:54 — with GitHub Actions Inactive
@abagusetty abagusetty temporarily deployed to aws January 24, 2023 13:48 — with GitHub Actions Inactive
@abagusetty abagusetty temporarily deployed to aws January 24, 2023 19:01 — with GitHub Actions Inactive
@abagusetty abagusetty temporarily deployed to aws January 24, 2023 21:30 — with GitHub Actions Inactive
@abagusetty abagusetty temporarily deployed to aws January 25, 2023 16:35 — with GitHub Actions Inactive
@abagusetty
Copy link
Contributor Author

abagusetty commented Jan 25, 2023

@steffenlarsen @bader Sorry about the delay. Relevant CUDA tests were fixed however ESIMD test is failing which I am not sure.

@bader
Copy link
Contributor

bader commented Jan 25, 2023

Failed Tests (1):
SYCL :: dword_atomic_smoke.cpp

@bader bader merged commit 9008a5d into intel:sycl Jan 25, 2023
@abagusetty abagusetty deleted the 2dmemcpy branch January 25, 2023 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@steffenlarsen steffenlarsen steffenlarsen approved these changes

@romanovvlad romanovvlad Awaiting requested review from romanovvlad romanovvlad was automatically assigned from intel/llvm-reviewers-cuda

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@abagusetty @bader @steffenlarsen