[SYCL] Update sycl complex implementation #8068
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/verify with intel/llvm-test-suite#1533 |
|
/verify with intel/llvm-test-suite#1533 |
|
/verify with intel/llvm-test-suite#1533 |
|
I wanted to check in on the status of this PR. It has passed all tests, and I believe it is ready to be merged. Is there any blocker preventing this from being reviewed or merged? @intel/llvm-reviewers-runtime @sergey-semenov |
|
@jle-quel, please, resolve merge conflicts. |
…sycl-complex-implementation
steffenlarsen
pushed a commit
to intel/llvm-test-suite
that referenced
this pull request
Mar 13, 2023
This PR updates the tests for the experimental sycl complex implementation. It tests the new unary operators `+` and `-`, the new functions `real` and `imag` and the variant of `conj`, `proj`, `arg`, `norm`, when the function is called with decimals as arguments. An overload of `test_valid_types` which takes a template template parameter that takes two typename parameters has been introduced to support the new `deci_test_cases`. Finally, the `test_cases` structure has been renamed to `cplx_test_cases` to be coherent with the new `deci_test_cases`. Depends on: intel/llvm#8068
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
This PR updates the tests for the experimental sycl complex implementation. It tests the new unary operators `+` and `-`, the new functions `real` and `imag` and the variant of `conj`, `proj`, `arg`, `norm`, when the function is called with decimals as arguments. An overload of `test_valid_types` which takes a template template parameter that takes two typename parameters has been introduced to support the new `deci_test_cases`. Finally, the `test_cases` structure has been renamed to `cplx_test_cases` to be coherent with the new `deci_test_cases`. Depends on: intel#8068
This was referenced Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the complex implementation.
From the POV of the complex's user, the interface does not change.
The modification made to the implementation are:
is_genfloatis true, which removes the duplication of the operatorsis_genfloatis true, which removes some boilerplate codeinlineattribute to different functionsvalue_typestd::enable_ifon free functionsllvm-test-suite: intel/llvm-test-suite#1533