Skip to content

[SYCL] Augment known_identity for std::complex and std::plus. #8425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 2, 2023
Merged

[SYCL] Augment known_identity for std::complex and std::plus. #8425

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d4c6320
[SYCL] Augment known_identity for std::complex and std::plus.
uditagarwal97 Feb 22, 2023
92225ac
Only support floating-point templates for std::complex.
uditagarwal97 Feb 22, 2023
be4de83
[SYCL][DOC] Update extension specification to extend sycl::known_iden…
uditagarwal97 Feb 27, 2023
990fcd8
Fix typo.
uditagarwal97 Feb 27, 2023
bc63143
[SYCL][DOCS] Minor formatting changes.
uditagarwal97 Feb 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions sycl/doc/extensions/proposed/sycl_ext_oneapi_complex_algorithms.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,18 @@ NOTE: `sycl::bit_and`, `sycl::bit_or`, `sycl::bit_xor`, `sycl::logical_and`,
because their behaviors are defined in terms of operators that `std::complex`
does not implement.

=== Known Identities

This extension adds the following known identities, augmenting https://registry.khronos.org/SYCL/specs/sycl-2020/html/sycl-2020.html#table.identities[Table 123] in the core SYCL specification:
[cols="5,30,70"]
[grid="rows"]
[options="header"]
|========================================
|Operator|Available When|Identity
|`sycl::plus`|`std::is_same_v<std::remove_cv_t<AccumulatorT>, std::complex<float>> \|\|
std::is_same_v<std::remove_cv_t<AccumulatorT>, std::complex<double>>`|`AccumulatorT{}`
|========================================

== Issues

None.
Expand Down
10 changes: 9 additions & 1 deletion sycl/include/sycl/known_identity.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,14 +63,22 @@ using IsLogicalOR =
bool_constant<std::is_same<BinaryOperation, sycl::logical_or<T>>::value ||
std::is_same<BinaryOperation, sycl::logical_or<void>>::value>;

template <typename T>
using isComplex =
bool_constant<std::is_same<T, std::complex<float>>::value ||
std::is_same<T, std::complex<double>>::value>;

// Identity = 0
template <typename T, class BinaryOperation>
using IsZeroIdentityOp =
bool_constant<(is_geninteger<T>::value &&
(IsPlus<T, BinaryOperation>::value ||
IsBitOR<T, BinaryOperation>::value ||
IsBitXOR<T, BinaryOperation>::value)) ||
(is_genfloat<T>::value && IsPlus<T, BinaryOperation>::value)>;
(is_genfloat<T>::value &&
IsPlus<T, BinaryOperation>::value) ||
(isComplex<T>::value &&
IsPlus<T, BinaryOperation>::value)>;

// Identity = 1
template <typename T, class BinaryOperation>
Expand Down