[SYCL] Fix constexpr initialization of vec for half #8503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vec currently requires that the underlying type has a constexpr default constructor. However, half does not have any guarantees that such a constructor exists. This commit removes this requirement by initializing the underlying data. Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com> Co-authored-by: Sachkov, Alexey <alexey.sachkov@intel.com>
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
againull
approved these changes
Mar 7, 2023
Contributor
Author
|
CUDA Failed Tests (1): |
whitneywhtsang
added a commit
to whitneywhtsang/llvm
that referenced
this pull request
Mar 11, 2023
…)" This reverts commit ba0ea79.
whitneywhtsang
added a commit
to whitneywhtsang/llvm
that referenced
this pull request
Mar 14, 2023
…ntel#8503)"" This reverts commit 3f342e4.
This was referenced Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vec currently requires that the underlying type has a constexpr default constructor. However, half does not have any guarantees that such a constructor exists. This commit removes this requirement by initializing the underlying data.