[SYCL][CMake] Disable win_proxy_loader build and link on non-Windows #8520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the win_proxy_loader is built and linked to the SYCL runtime on all platforms, but only carries meaning on Windows. Currently this causes issues as the corresponding library is not installed on non-Windows targets. Instead of installing it on non-Windows targets, this commit makes it only build and link to the SYCL runtime library when building on Windows. Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
|
This should help fix llvm-test-suite CI for Linux. |
dm-vodopyanov
approved these changes
Mar 3, 2023
|
CUDA Failed Tests (1): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the win_proxy_loader is built and linked to the SYCL runtime on all platforms, but only carries meaning on Windows. Currently this causes issues as the corresponding library is not installed on non-Windows targets. Instead of installing it on non-Windows targets, this commit makes it only build and link to the SYCL runtime library when building on Windows.