Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL] Filter out unneeded device images with lower state than requested #8523

Merged
merged 4 commits into from
Mar 21, 2023

Conversation

sergey-semenov
Copy link
Contributor

@sergey-semenov sergey-semenov commented Mar 2, 2023

When fetching device images compatible with non-input states, we can
ignore an image if another one with a higher state is available for all
the possible kernel-device pairs. This patch adds the logic for
filtering out such unnecessary images so that we can avoid JIT
compilation if both AOT and SPIRV images are present.

@sergey-semenov sergey-semenov temporarily deployed to aws March 2, 2023 22:34 — with GitHub Actions Inactive
@sergey-semenov sergey-semenov temporarily deployed to aws March 3, 2023 06:05 — with GitHub Actions Inactive
@sergey-semenov sergey-semenov temporarily deployed to aws March 3, 2023 06:48 — with GitHub Actions Inactive
When fetching device images compatible with non-input states, we can
ignore an image if another one with a higher state is available for all
the possible kernel-device pairs. This patch adds the logic for
filtering out such unnecessary images so that we can avoid JIT
compilation if both AOT and SPIRV images are present.
@sergey-semenov sergey-semenov marked this pull request as ready for review March 14, 2023 17:52
@sergey-semenov sergey-semenov requested a review from a team as a code owner March 14, 2023 17:52
@sergey-semenov sergey-semenov requested a review from againull March 14, 2023 17:52
@sergey-semenov sergey-semenov temporarily deployed to aws March 14, 2023 18:01 — with GitHub Actions Inactive
@sergey-semenov sergey-semenov temporarily deployed to aws March 15, 2023 12:18 — with GitHub Actions Inactive
@sergey-semenov sergey-semenov temporarily deployed to aws March 15, 2023 12:46 — with GitHub Actions Inactive
@sergey-semenov
Copy link
Contributor Author

@againull Could you please have a look?

@sergey-semenov sergey-semenov requested a review from againull March 21, 2023 12:17
@sergey-semenov sergey-semenov temporarily deployed to aws March 21, 2023 12:42 — with GitHub Actions Inactive
@sergey-semenov sergey-semenov temporarily deployed to aws March 21, 2023 13:17 — with GitHub Actions Inactive
@sergey-semenov sergey-semenov temporarily deployed to aws March 21, 2023 15:53 — with GitHub Actions Inactive
@sergey-semenov sergey-semenov temporarily deployed to aws March 21, 2023 19:24 — with GitHub Actions Inactive
@againull
Copy link
Contributor

CI failure on L0 backend:
Failed Tests (1):
SYCL :: Plugin/level_zero_imm_cmdlist_per_thread.cpp

is known and expected to be fixed by intel/llvm-test-suite#1674

@againull againull merged commit 61e5101 into intel:sycl Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants