[SYCL] Fix weak_object and owner_less for device objects #8740
Conversation
This commit fixes an issue where weak_object and in turn owner_less would fail to construct for SYCL object types that are usable on device. This was due to these object types only having an impl on host. As a result the kernel compilation would fail to get the impl of these. Since weak_object isn't intended for use inside kernels, this was fixed by using a dummy weak_ptr during kernel compilation to make it act like it is containing a weak pointer. Previously this was not found in unittests because they are not compiled with the SYCL compiler. To avoid this breaking in the future, these tests are moved to the test-suite. Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
|
/verify with intel/llvm-test-suite#1678 |
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
|
@intel/llvm-reviewers-runtime | @sergey-semenov - Friendly ping. |
There was a problem hiding this comment.
LGTM overall.
Although, do you think it would make sense to keep the unit tests and instead add a smaller device compilation only test for device objects to keep device compilation to a minimum in these tests? Or would there be too much code duplication between the two?
I worry that we would run the risk of once again ignore device-side issues by splitting it up. Most of the failures were either due to some invalid behavior during device-side compilation or due to the unittest host-compiler behaving differently than our compiler. Furthermore, a certain version of MSVC is having problem with the implementation, which manifests if they are used in the unittests but shouldn't manifest in e2e unless we use MSVC as the host compiler. |
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
|
Failed Tests (1): |
This commit fixes an issue where weak_object and in turn owner_less would fail to construct for SYCL object types that are usable on device. This was due to these object types only having an impl on host. As a result the kernel compilation would fail to get the impl of these. Since weak_object isn't intended for use inside kernels, this was fixed by using a dummy weak_ptr during kernel compilation to make it act like it is containing a weak pointer.
Previously this was not found in unittests because they are not compiled with the SYCL compiler. To avoid this breaking in the future, these tests are moved to the test-suite.