Skip to content

[SYCL] Update native_specialization_constant when no specialization constants are present #8868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 31, 2023
Merged

[SYCL] Update native_specialization_constant when no specialization constants are present #8868

merged 3 commits into from
Mar 31, 2023

Conversation

@jzc
Copy link
Contributor

@jzc jzc commented Mar 29, 2023

From the spec update KhronosGroup/SYCL-Docs#346, native_specialization_constant() should return false when the kernel bundle contains no specialization constants.

@jzc
[SYCL] Update native_specialization_constant when no specialization c…
d1495cb 
…onstants are present

Signed-off-by: Cai, Justin <justin.cai@intel.com>
@jzc jzc requested a review from a team as a code owner March 29, 2023 23:20
@jzc jzc requested a review from bso-intel March 29, 2023 23:20
@jzc jzc temporarily deployed to aws March 30, 2023 02:37 — with GitHub Actions Inactive
@jzc jzc temporarily deployed to aws March 30, 2023 07:55 — with GitHub Actions Inactive
@AlexeySachkov AlexeySachkov requested a review from a team March 30, 2023 09:48
steffenlarsen
steffenlarsen approved these changes Mar 30, 2023
View reviewed changes
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit, but looks good overall!

jzc added 2 commits March 30, 2023 08:38
@jzc
Address review comments
d5ac140 
Signed-off-by: Cai, Justin <justin.cai@intel.com>
@jzc
Merge remote-tracking branch 'intel/sycl' into native-specialization-…
72570e8 
…constant-empty
@jzc jzc temporarily deployed to aws March 30, 2023 17:13 — with GitHub Actions Inactive
@jzc jzc temporarily deployed to aws March 30, 2023 19:08 — with GitHub Actions Inactive
@steffenlarsen
Copy link
Contributor

Failed Tests (1):
SYCL :: AtomicRef/atomic_memory_order_acq_rel.cpp
Disabled in #8885.

@steffenlarsen steffenlarsen merged commit 9eb1184 into intel:sycl Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexeySachkov AlexeySachkov AlexeySachkov approved these changes

@bso-intel bso-intel Awaiting requested review from bso-intel bso-intel is a code owner automatically assigned from intel/llvm-reviewers-runtime

+1 more reviewer

@steffenlarsen steffenlarsen steffenlarsen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jzc @steffenlarsen @AlexeySachkov