Skip to content

[SYCL][UR] Use official device info property for c-slices #8891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2023
Merged

[SYCL][UR] Use official device info property for c-slices #8891

merged 1 commit into from
Mar 31, 2023

Conversation

@jandres742
Copy link
Contributor

Spec has now UR_DEVICE_PARTITION_BY_CSLICE, so remove UR_EXT_DEVICE_PARTITION_PROPERTY_FLAG_BY_CSLICE.

@jandres742 jandres742 requested a review from a team as a code owner March 30, 2023 20:15
@jandres742 jandres742 temporarily deployed to aws March 30, 2023 22:07 — with GitHub Actions Inactive
@jandres742 jandres742 temporarily deployed to aws March 31, 2023 00:48 — with GitHub Actions Inactive
@jandres742
Copy link
Contributor Author

this is failing in

********************
Failed Tests (1):
  SYCL :: AtomicRef/atomic_memory_order_acq_rel.cpp

tracked in #8847

@jandres742
Copy link
Contributor Author

rebased to include fix for flaky test, #8885.

[SYCL][UR] Use official device info property for c-slices
4df238a 
Spec has now UR_DEVICE_PARTITION_BY_CSLICE, so remove
UR_EXT_DEVICE_PARTITION_PROPERTY_FLAG_BY_CSLICE.

Signed-off-by: Jaime Arteaga <jaime.a.arteaga.molina@intel.com>
@jandres742 jandres742 temporarily deployed to aws March 31, 2023 05:16 — with GitHub Actions Inactive
@jandres742 jandres742 temporarily deployed to aws March 31, 2023 07:10 — with GitHub Actions Inactive
@bader bader merged commit df9f5b0 into intel:sycl Mar 31, 2023
veselypeta pushed a commit to veselypeta/llvm that referenced this pull request Sep 21, 2023
[SYCL][UR] Use official device info property for c-slices (intel#8891)
0ba5e4f 
Spec has now UR_DEVICE_PARTITION_BY_CSLICE, so remove
UR_EXT_DEVICE_PARTITION_PROPERTY_FLAG_BY_CSLICE.

Signed-off-by: Jaime Arteaga <jaime.a.arteaga.molina@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@smaslov-intel smaslov-intel smaslov-intel approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jandres742 @smaslov-intel @bader