Skip to content

[NFC][SYCL][L0] Add infrastructure to know backend of a platform #9067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
againull merged 3 commits into from
Apr 20, 2023
Merged

[NFC][SYCL][L0] Add infrastructure to know backend of a platform #9067

againull merged 3 commits into from
Apr 20, 2023

Conversation

@smaslov-intel
Copy link
Contributor

@smaslov-intel smaslov-intel commented Apr 13, 2023 •
edited
Loading

In subsequent PR the "backend" knowledge will move from "plugin" to "platform"

@smaslov-intel smaslov-intel requested review from a team as code owners April 13, 2023 23:25
@smaslov-intel smaslov-intel temporarily deployed to aws April 14, 2023 01:40 — with GitHub Actions Inactive
jandres742
jandres742 reviewed Apr 14, 2023
View reviewed changes
Copy link
Contributor

@jandres742 jandres742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

jchlanda
jchlanda approved these changes Apr 14, 2023
View reviewed changes
Copy link
Contributor

@jchlanda jchlanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CUDA/HIP LGTM

jchlanda
jchlanda reviewed Apr 14, 2023
View reviewed changes
steffenlarsen
steffenlarsen reviewed Apr 14, 2023
View reviewed changes
@smaslov-intel smaslov-intel temporarily deployed to aws April 14, 2023 17:38 — with GitHub Actions Inactive
@smaslov-intel smaslov-intel temporarily deployed to aws April 14, 2023 19:54 — with GitHub Actions Inactive
@smaslov-intel
Copy link
Contributor Author

smaslov-intel commented Apr 14, 2023 •
edited
Loading

@intel/llvm-reviewers-runtime : hmm, is it true/correct that pi.h is included into every SYCL program?
Then we need UR on the same level as SYCL includes.

In file included from /__w/llvm/llvm/src/clang/test/CodeGenSYCL/sycl-add-opt-level-attrib.cpp:9:
In file included from /__w/llvm/llvm/build/bin/../include/sycl/sycl.hpp:11:
In file included from /__w/llvm/llvm/build/bin/../include/sycl/accessor.hpp:12:
In file included from /__w/llvm/llvm/build/bin/../include/sycl/atomic.hpp:12:
In file included from /__w/llvm/llvm/build/bin/../include/sycl/access/access.hpp:11:
In file included from /__w/llvm/llvm/build/bin/../include/sycl/detail/common.hpp:14:
In file included from /__w/llvm/llvm/build/bin/../include/sycl/detail/pi.hpp:19:
/__w/llvm/llvm/build/bin/../include/sycl/detail/pi.h:127:10: fatal error: 'ur_api.h' file not found
#include <ur_api.h>
^~~~~~~~~~
1 error generated.

@smaslov-intel
[NFC][SYCL][L0] Add infrastructure to know backend of a platform
52d78f6 
Signed-off-by: Sergey V Maslov <sergey.v.maslov@intel.com>
@smaslov-intel
Copy link
Contributor Author

smaslov-intel commented Apr 19, 2023

@intel/llvm-reviewers-runtime : hmm, is it true/correct that pi.h is included into every SYCL program? Then we need UR on the same level as SYCL includes.

In file included from /__w/llvm/llvm/src/clang/test/CodeGenSYCL/sycl-add-opt-level-attrib.cpp:9:
In file included from /__w/llvm/llvm/build/bin/../include/sycl/sycl.hpp:11:
In file included from /__w/llvm/llvm/build/bin/../include/sycl/accessor.hpp:12:
In file included from /__w/llvm/llvm/build/bin/../include/sycl/atomic.hpp:12:
In file included from /__w/llvm/llvm/build/bin/../include/sycl/access/access.hpp:11:
In file included from /__w/llvm/llvm/build/bin/../include/sycl/detail/common.hpp:14:
In file included from /__w/llvm/llvm/build/bin/../include/sycl/detail/pi.hpp:19:
/__w/llvm/llvm/build/bin/../include/sycl/detail/pi.h:127:10: fatal error: 'ur_api.h' file not found
#include <ur_api.h>
^~~~~~~~~~
1 error generated.

I have changed the PR to not use UR directly from PI, and added this translation
https://github.com/intel/llvm/pull/9067/files#diff-f1103e5442bf4f71ac0fb3cd9aa969042ee3e864e7b3e8c6f3255b7162ffadfeR168

In a subsequent PR we need to move UR to the top level.

@smaslov-intel smaslov-intel temporarily deployed to aws April 19, 2023 04:33 — with GitHub Actions Inactive
@smaslov-intel
fix build
91152d0 
Signed-off-by: Sergey V Maslov <sergey.v.maslov@intel.com>
@smaslov-intel smaslov-intel temporarily deployed to aws April 19, 2023 19:56 — with GitHub Actions Inactive
@smaslov-intel
update abi dump
6939348 
Signed-off-by: Sergey V Maslov <sergey.v.maslov@intel.com>
@smaslov-intel smaslov-intel temporarily deployed to aws April 20, 2023 01:19 — with GitHub Actions Inactive
@smaslov-intel
Copy link
Contributor Author

smaslov-intel commented Apr 20, 2023

@steffenlarsen , @againull : kind ping

@smaslov-intel smaslov-intel temporarily deployed to aws April 20, 2023 03:57 — with GitHub Actions Inactive
steffenlarsen
steffenlarsen approved these changes Apr 20, 2023
View reviewed changes
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@againull againull merged commit ef0455b into intel:sycl Apr 20, 2023
jandres742 pushed a commit to jandres742/llvm that referenced this pull request Apr 21, 2023
Port Add infrastructure to know backend of a platform
8f92a96 
intel#9067

Signed-off-by: Jaime Arteaga <jaime.a.arteaga.molina@intel.com>
jandres742 pushed a commit to jandres742/llvm that referenced this pull request Apr 24, 2023
Port Add infrastructure to know backend of a platform
7f0f96c 
intel#9067

Signed-off-by: Jaime Arteaga <jaime.a.arteaga.molina@intel.com>
jandres742 pushed a commit to jandres742/llvm that referenced this pull request May 3, 2023
Port Add infrastructure to know backend of a platform
5d18fe8 
intel#9067

Signed-off-by: Jaime Arteaga <jaime.a.arteaga.molina@intel.com>
jandres742 pushed a commit to jandres742/llvm that referenced this pull request May 16, 2023
Port Add infrastructure to know backend of a platform
e8a964a 
intel#9067

Signed-off-by: Jaime Arteaga <jaime.a.arteaga.molina@intel.com>
jandres742 pushed a commit to jandres742/llvm that referenced this pull request May 23, 2023
Port Add infrastructure to know backend of a platform
6df1d9b 
intel#9067

Signed-off-by: Jaime Arteaga <jaime.a.arteaga.molina@intel.com>
jandres742 pushed a commit to jandres742/llvm that referenced this pull request May 26, 2023
Port Add infrastructure to know backend of a platform
df8ca58 
intel#9067

Signed-off-by: Jaime Arteaga <jaime.a.arteaga.molina@intel.com>
veselypeta pushed a commit to veselypeta/llvm that referenced this pull request Sep 21, 2023
@smaslov-intel
[NFC][SYCL][L0] Add infrastructure to know backend of a platform (int…
8920959 
…el#9067)

In subsequent PR the "backend" knowledge will move from "plugin" to
"platform"

---------

Signed-off-by: Sergey V Maslov <sergey.v.maslov@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@v-klochkov v-klochkov v-klochkov approved these changes

@againull againull againull approved these changes

@steffenlarsen steffenlarsen steffenlarsen approved these changes

@npmiller npmiller Awaiting requested review from npmiller npmiller was automatically assigned from intel/llvm-reviewers-cuda

@bso-intel bso-intel Awaiting requested review from bso-intel bso-intel is a code owner automatically assigned from intel/llvm-reviewers-runtime

+2 more reviewers

@jchlanda jchlanda jchlanda approved these changes

@jandres742 jandres742 jandres742 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@smaslov-intel @jchlanda @jandres742 @v-klochkov @againull @steffenlarsen