Skip to content

[SYCL] Throw for invalid global_work_size query#9072

Merged
steffenlarsen merged 3 commits intointel:syclfrom
KornevNikita:global_work_size
Apr 19, 2023
Merged

[SYCL] Throw for invalid global_work_size query#9072
steffenlarsen merged 3 commits intointel:syclfrom
KornevNikita:global_work_size

Conversation

@KornevNikita
Copy link
Contributor

SYCL2020:

This descriptor may only be used if the device type is device_type::custom or if the kernel is a built-in kernel. Attempting to use this descriptor for other devices or kernels throws an exception with the errc::invalid error code.

The previous implementation is based on handling OpenCL exception, but the other backends don't throw anything, so it works only on OCL. This approch is more generic.

SYCL2020:

This descriptor may only be used if the device type is device_type::custom or
if the kernel is a built-in kernel. Attempting to use this descriptor for other
devices or kernels throws an exception with the errc::invalid error code.

The previous implementation is based on handling OpenCL exception, but
the other backends don't throw anything, so it works only on OCL. This
approch is more generic.
@KornevNikita KornevNikita requested a review from a team as a code owner April 14, 2023 12:36
@KornevNikita KornevNikita temporarily deployed to aws April 14, 2023 13:02 — with GitHub Actions Inactive
@KornevNikita KornevNikita temporarily deployed to aws April 14, 2023 19:12 — with GitHub Actions Inactive
@KornevNikita
Copy link
Contributor Author

KornevNikita commented Apr 17, 2023

Waiting for #9061 to be merged, because I need isBuiltInKernel() function, which was introduced there.

@KornevNikita KornevNikita temporarily deployed to aws April 18, 2023 13:29 — with GitHub Actions Inactive
@KornevNikita KornevNikita temporarily deployed to aws April 18, 2023 14:27 — with GitHub Actions Inactive
@KornevNikita
Copy link
Contributor Author

I guess SYCL Pre Commit / Windows / L0 GEN12 LLVM Test Suite (pull_request_target) failure is unrelated. Or no?
@intel/sycl-language-enabling-triage take a look please.

@maarquitos14
Copy link
Contributor

I guess SYCL Pre Commit / Windows / L0 GEN12 LLVM Test Suite (pull_request_target) failure is unrelated. Or no? @intel/sycl-language-enabling-triage take a look please.

At first glance, it does not look related, but https://github.com/intel/llvm/actions/runs/4739521267/jobs/8414728080?pr=9113 passed just half an hour ago. Could you try and merge the latest changes in origin/sycl and see if that helps?

@KornevNikita
Copy link
Contributor Author

I guess SYCL Pre Commit / Windows / L0 GEN12 LLVM Test Suite (pull_request_target) failure is unrelated. Or no? @intel/sycl-language-enabling-triage take a look please.

At first glance, it does not look related, but https://github.com/intel/llvm/actions/runs/4739521267/jobs/8414728080?pr=9113 passed just half an hour ago. Could you try and merge the latest changes in origin/sycl and see if that helps?

Now there are some more PRs, so we can see that it's unrelated - e.g. #9112

@steffenlarsen
Copy link
Contributor

Failed Tests (1):
SYCL :: Plugin/level_zero_imm_cmdlist_per_thread.cpp - Reported in #9117.

Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@KornevNikita KornevNikita temporarily deployed to aws April 19, 2023 10:42 — with GitHub Actions Inactive
@KornevNikita KornevNikita temporarily deployed to aws April 19, 2023 11:31 — with GitHub Actions Inactive
@steffenlarsen steffenlarsen merged commit 6143388 into intel:sycl Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants