[SYCL] Fix handling of mem_channel buffer property #9203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the sycl::property::buffer::mem_channel handling when creating a buffer with the property. Additionally it fixes the associated device info query and aspect check. Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
steffenlarsen
commented
Apr 25, 2023
| if (ParamName == PI_EXT_INTEL_DEVICE_INFO_MEM_CHANNEL_SUPPORT) { | ||
| ReturnHelper ReturnValue(ParamValueSize, ParamValue, ParamValueSizeRet); | ||
| return ReturnValue(pi_bool{false}); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
@smaslov-intel - I did a similar work-around in #8954. Is there a better way of doing it?
Contributor
There was a problem hiding this comment.
@steffenlarsen : Yes, let's not add new stuff here.
Please temporary add UR extension here:
And note @kbenzie to promote it into UR.
The the handling would naturally go into https://github.com/intel/llvm/blob/sycl/sycl/plugins/unified_runtime/ur/adapters/level_zero/ur_level_zero.cpp
Contributor
There was a problem hiding this comment.
I was not aware of this list of constants until now. Do lines 23-57 encapsulate these UR_EXT_* symbols or are there additional ones?
Contributor
There was a problem hiding this comment.
Found oneapi-src/unified-runtime#374 which seems to cover theses, added mention of this.
added 2 commits
April 25, 2023 08:11
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
aelovikov-intel
approved these changes
Apr 25, 2023
Contributor
added 2 commits
April 27, 2023 02:33
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
jandres742
pushed a commit
to jandres742/llvm
that referenced
this pull request
May 3, 2023
intel#9203 Signed-off-by: Jaime Arteaga <jaime.a.arteaga.molina@intel.com>
jandres742
pushed a commit
to jandres742/llvm
that referenced
this pull request
May 16, 2023
intel#9203 Signed-off-by: Jaime Arteaga <jaime.a.arteaga.molina@intel.com>
jandres742
pushed a commit
to jandres742/llvm
that referenced
this pull request
May 23, 2023
intel#9203 Signed-off-by: Jaime Arteaga <jaime.a.arteaga.molina@intel.com>
jandres742
pushed a commit
to jandres742/llvm
that referenced
this pull request
May 26, 2023
intel#9203 Signed-off-by: Jaime Arteaga <jaime.a.arteaga.molina@intel.com>
veselypeta
pushed a commit
to veselypeta/llvm
that referenced
this pull request
Sep 21, 2023
This commit fixes the sycl::property::buffer::mem_channel handling when creating a buffer with the property. Additionally it fixes the associated device info query and aspect check. --------- Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the sycl::property::buffer::mem_channel handling when creating a buffer with the property. Additionally it fixes the associated device info query and aspect check.