[SYCL] Default work-group sizes based on max #952
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bader
reviewed
Dec 19, 2019
| @@ -681,15 +681,12 @@ static void adjustNDRangePerKernel(NDRDescT &NDR, RT::PiKernel Kernel, | |||
|
|
|||
| if (WGSize[0] == 0) { | |||
There was a problem hiding this comment.
Is this condition valid to represent all "default work-group size" cases?
There was a problem hiding this comment.
WGSize[0] == 0 means user hasn't asked for a specific local size using attribute((reqd_work_group_size(X, Y, Z)) only.
|
@StuartDAdams |
vladimirlaz
pushed a commit
to vladimirlaz/llvm
that referenced
this pull request
Feb 7, 2020
CONFLICT (content): Merge conflict in clang/lib/Frontend/CompilerInvocation.cpp
|
@StuartDAdams, ping. |
|
I have responded to some of the concerns and I agree with @AlexeySachkov that this may not be the most stable solution. I've suggested a different solution and will do regression tests once we reach a conclusion on what to do. |
|
@bader, @romanovvlad can you please review and comment on the latest approach. Please summarize what you think needs to be addressed. |
|
@romanovvlad please review |
nyalloc
force-pushed
the
stuart/default-work-group-size
branch
from
9897d54 to
247634f
Compare
romanovvlad
reviewed
Mar 24, 2020
nyalloc
force-pushed
the
stuart/default-work-group-size
branch
from
4439522 to
f61ebb5
Compare
romanovvlad
previously approved these changes
Mar 24, 2020
|
@StuartDAdams, it looks like I merged some conflicting changes recently. Could you update the RP, please? |
Of course, I will do this ASAP. |
Signed-off-by: Stuart Adams <stuart.adams@codeplay.com>
nyalloc
force-pushed
the
stuart/default-work-group-size
branch
from
f61ebb5 to
3044baf
Compare
Signed-off-by: Stuart Adams <stuart.adams@codeplay.com>
nyalloc
force-pushed
the
stuart/default-work-group-size
branch
from
4be2092 to
646c65c
Compare
bader
approved these changes
Mar 24, 2020
alexbatashev
added a commit
to alexbatashev/llvm
that referenced
this pull request
Mar 27, 2020
…hinx * upstream/sycl: (357 commits) [Support] Implement a simple tabular data management library (intel#1358) [Support] Implement a property set I/O library (intel#1357) [SYCL] Fix buffer constructor using iterators (intel#1386) [SYCL][FPGA] Enable a set of loop attributes (intel#1312) [Driver][SYCL][FPGA] Proper dependency output location when given /Fo<dir> (intel#1346) [SPIR-V] Enabling SPIR-V builtin lookup in device SYCL mode (intel#1384) [SYCL][NFC] Unify setting kernel arguments (intel#1379) [SYCL][Doc] First revision of standard layout relaxation extension (intel#1344) [SYCL] Fixed sub-buffer alloca search (intel#1385) [SYCL][FPGA] Emit multiple IR variants for the IVDep attribute (intel#1383) [SYCL] Add experimental flag to enable front-end optimizations (intel#1376) [SYCL] Remove unexpected double in complex SPIR-V for float support (intel#1381) [SYCL] Default work-group sizes based on max (intel#952) [SYCL][CUDA] Fix usage of multiple backends in the same program (intel#1252) [SPIR-V] Add SPIR-V builtin definitions to the builtin lookup. [SPIR-V] Add macro definition when -fdeclare-spirv-builtins is activated [SYCL] Fix sycl_generic printing [SYCL] Support intel::reqd_work_group_size (intel#1328) [SYCL][NFC] Make the RT::PiPlugin object private (intel#1375) [SPIRV] Add convergent attribute to SPIR-V built-ins (intel#1373) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes ensures that the default work-group size does not exceed the allowed maximum sizes.
Signed-off-by: Stuart Adams stuart.adams@codeplay.com