LLVM and SPIRV-LLVM-Translator pulldown (WW22) #9694
Conversation
We already early-out at the top of the function.
As reported on https://reviews.llvm.org/D150375#4367861 and following, this change causes PDT invalidation issues. Revert it and dependent commits. This reverts commit 0524534. This reverts commit ced90d1. This reverts commit 9f992cc. This reverts commit 1b12320.
All result handles must be set in case of success. Differential Revision: https://reviews.llvm.org/D151705
Do not replace uses inside the body of `scf.forall` ops with results of the same op. Differential Revision: https://reviews.llvm.org/D151706
Clarify the restrictions on actions that are implied by the implementation as a post-order walk.
As raised on Issue #62602 - the IceLake scheduler model is still mainly a copy of the SkylakeServer model. This initial commit just fixes the ROB/MicroOpBufferSize to match the size reported on WikiChip/Agner, further fixes to follow in later commits.
This fold is buggy if the constant adjustment overflows. Additionally, since we now canonicalize to min/max intrinsics, the constants picked here don't actually matter, as long as SPF still recognizes the pattern. Fixes llvm/llvm-project#62088.
Create SchedWrites, WriteRes for reduction instructions that are SEW specific. Future patches can use these resources to customize the behavior of these resources depending on SEW. Differential Revision: https://reviews.llvm.org/D151470
At inserting of InterfaceMap, a debug message lacked a newline, so it repeatedly displayed this message within a single line. Clean up the debug log by inserting a newline at the end of the message. Reviewed By: rriddle Differential Revision: https://reviews.llvm.org/D150182
This is pretty straight forward in the basic form. I did need to move the slideup matching earlier, but that looks generally profitable on it's own. As follow ups, I plan to explore the v(f)slide1down variants, and see what I can do to canonicalize the shuffle then insert pattern (see _inverse tests at the end of the vslide1up.ll test). Differential Revision: https://reviews.llvm.org/D151468
Adds a new HLFIR operation for the ALL intrinsic according to the design set out in flang/docs/HighLevel.md Differential Revision: https://reviews.llvm.org/D151090
Carries out the lowering of the all intrinsic into HLFIR Differential Revision: https://reviews.llvm.org/D151111
Depends on: D151111 Differential Revision: https://reviews.llvm.org/D151415
This fixes a crash caused by legal treating a scalable GEP as invariant, but isUniformAfterVectorization does not handle GEPs. Partially fixes llvm/llvm-project#60831. Reviewed By: Ayal Differential Revision: https://reviews.llvm.org/D144434
This patch uses castAs instead of getAs which will assert if the type doesn't match in clang::Type::getSveEltType(clang::ASTContext const &) Reviewed By: erichkeane Differential Revision: https://reviews.llvm.org/D151525
The transform dialect has been around for a while and is sufficiently stable at this point. Add the first three chapters of the tutorial describing its usage and extension. Reviewed By: springerm Differential Revision: https://reviews.llvm.org/D151491
… friends This allows types to be considered trivially equality comparable if a defaulted hidden friend is used. Reviewed By: erichkeane Spies: cfe-commits Differential Revision: https://reviews.llvm.org/D151623
Update collectLoopUniforms to identify uniform pointers using Legal::isUniform. This is more powerful and brings pointer classification here in sync with setCostBasedWideningDecision which uses isUniformMemOp. The existing mis-match in reasoning can causes crashes due to D134460, which is fixed by this patch. Fixes llvm/llvm-project#60831. Reviewed By: Ayal Differential Revision: https://reviews.llvm.org/D150991
The ability to add attributes to payload IR is useful functionality independent of any dialect. This is added here through `transform.annotate` by enabling attributes tied to a `TransformParamTypeInterface` (which internally refers to an Attribute) to be added to a target operation by name. The AnnotateOp does not produce a new handle as no existing handles should be affected by adding an attribute. Existing attributes on the payload with the same name will be overwritten. Differential Revision: https://reviews.llvm.org/D151689
Add support for the `llvm::TargetExtType` to the MLIR LLVM dialect. Target extension types were introduced to represent target-specific types, which are opaque to the compiler and optimizations. The patch also enforces some of the constraints defined for the target extension type in the LLVM language reference manual. Signed-off-by: Lukas Sommer <lukas.sommer@codeplay.com> Reviewed By: ftynse, gysit, Dinistro Differential Revision: https://reviews.llvm.org/D151446
…king" This reverts commit c194a5e. The previous community commit which removed the definition and use of this routine AddStaticDeviceLibsPostLinking was reverted by Nikita.
…ion calls Reviewed By: steakhal Differential Revision: https://reviews.llvm.org/D151726
They are redundant with the [[fallthrough]]; attribute that follows. Reviewed By: steakhal Differential Revision: https://reviews.llvm.org/D151723
…xDeinterleaving pass This patch updates several functions in LLVM's IR generation code to accept an IRBuilder object as an argument, rather than an Instruction that indicates the insertion point for new instructions. This change is necessary to handle sophisticated -Ofast optimization cases from D148558 where it's unclear which instructions should be used as the insertion point for new operations. Differential Revision: https://reviews.llvm.org/D148703
|
/merge |
|
Wed 07 Jun 2023 06:40:47 AM UTC --- Start to merge the commit into sycl branch. It will take several minutes. |
|
Wed 07 Jun 2023 06:45:08 AM UTC --- Merge failed with error: Please check whether the PR is mergeable |
|
/merge |
|
Wed 07 Jun 2023 01:07:02 PM UTC --- Merge failed with error: Comment user is not in llvm_gatekeepers group or doesn't have merge right for target branch. Please contact with admins of the repo if there is any question. |
|
/merge |
|
Wed 07 Jun 2023 01:09:10 PM UTC --- Merge failed with error: Comment user is not in llvm_gatekeepers group or doesn't have merge right for target branch. Please contact with admins of the repo if there is any question. |
|
@againull I tried to merge the branch using git command, it can be merged without conflicts (and there is no conflict detected by github as well), so I think this should be mergeable. Maybe it is bb-sycl bot bug? Can you try again? |
|
/merge |
|
Wed 07 Jun 2023 01:58:26 PM UTC --- Start to merge the commit into sycl branch. It will take several minutes. |
|
Wed 07 Jun 2023 02:04:02 PM UTC --- Merge failed with error: Please check whether the PR is mergeable |
Is there a log somewhere that we can see WHY it is failing? |
@jsji I've sent an email with details. I wasn't able to reach the log at first so decided to try merging sycl branch. |
Thanks @againull . Yes, please merge it manually first if you have permission to do so. |
|
Thu 08 Jun 2023 05:28:43 AM UTC --- Start to merge the commit into sycl branch. It will take several minutes. |
|
Thu 08 Jun 2023 05:33:06 AM UTC --- Merge the branch in this PR to base automatically. Will close the PR later. |
20 participants
LLVM: llvm/llvm-project@40c26ec
SPIRV-LLVM-Translator: KhronosGroup/SPIRV-LLVM-Translator@c2ff406