[SYCL][ESIMD]Adjust the test to pass when used with fast-math option#9723
Closed
fineg74 wants to merge 1 commit intointel:syclfrom
Closed
[SYCL][ESIMD]Adjust the test to pass when used with fast-math option#9723fineg74 wants to merge 1 commit intointel:syclfrom
fineg74 wants to merge 1 commit intointel:syclfrom
Conversation
v-klochkov
reviewed
Jun 2, 2023
| float std_result_atan = std::atan2(input_x, input_y); | ||
|
|
||
| if (std::fabs(std_result_atan - vector_output_atan2[iy * size + ix]) > | ||
| 0.0001f) { |
Contributor
There was a problem hiding this comment.
- The test without fast-math passes with the difference 0.0001f. With the proposed change the test compiled without fast-math might eventually start giving difference 3.0f (which most-likely is due to some error), and such error would not be shown by the updated test.
Maybe this would work better:
#ifdef __FAST_MATH__ <use one tolerance> #else <use 0.0001f tolerance> #endif
- 3.2f seems like quite a big number. It may be Ok for fast-math and atan depending on the input values, I don't know.
Are you sure the device code computes result correctly taken into account such a big difference?
Contributor
|
This pull request is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be automatically closed in 30 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.