[SYCL][DOC] Add sycl_ext_oneapi_work_group_local #9799
Merged
+315
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces support for work-group local allocations at program and function scope, lifting some of the restrictions of sycl_ext_oneapi_group_local_memory. Signed-off-by: John Pennycook <john.pennycook@intel.com>
Pennycook
added
the
spec extension
gmlueck
reviewed
Jun 27, 2023
Contributor
gmlueck
left a comment
gmlueck
left a comment
There was a problem hiding this comment.
I think this generally looks good, but a couple of comments below.
sycl/doc/extensions/proposed/sycl_ext_oneapi_work_group_local.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/proposed/sycl_ext_oneapi_work_group_local.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/proposed/sycl_ext_oneapi_work_group_local.asciidoc
Outdated
Show resolved
Hide resolved
- Use sizeof(int) to highlight that the unit is bytes. - Use M to highlight that runtime values are supported.
gmlueck
reviewed
Jun 28, 2023
sycl/doc/extensions/proposed/sycl_ext_oneapi_work_group_local.asciidoc
Outdated
Show resolved
Hide resolved
Co-authored-by: Greg Lueck <gregory.m.lueck@intel.com>
gmlueck
approved these changes
Jun 28, 2023
Contributor
Author
|
@intel/llvm-gatekeepers: This is ready to be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces support for work-group local allocations at program and function scope, lifting some of the restrictions of sycl_ext_oneapi_group_local_memory.