[SYCL][CUDA] Re-enable same_unnamed_kernels test #9942
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Can this test be also enabled for HIP backend, as it seems to work on my end. |
Contributor
Author
|
It seems this was already re-enabled for HIP now. Friendly ping @sergey-semenov @intel/llvm-reviewers-runtime |
I believe the issue was that the tests wasn't getting the CUDA target flags properly and this would have been fixed as part of the E2E tests rework.
npmiller
force-pushed
the
same-unnamed
branch
from
e2856ae to
d7b9a86
Compare
Contributor
Author
|
ping @intel/llvm-reviewers-runtime @sergey-semenov @steffenlarsen |
sergey-semenov
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe the issue was that the tests wasn't getting the CUDA target flags properly and this would have been fixed as part of the E2E tests rework (in #9336).
Fixes: #9174