Skip to content

Conversation

@jchlanda
Copy link
Contributor

Since 94f7c96 landed the -fno-lifetime-dse option is added to the compilation database, if using non-llvm based toolchains, this option is not compatible with clang and as tools invocation in libclc does not relay on the content of the DB, use the default, empty one.

Also fix deprecated makeArrayRef warning.

cc: abagusetty

Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jchlanda jchlanda temporarily deployed to aws June 19, 2023 13:20 — with GitHub Actions Inactive
@jchlanda jchlanda temporarily deployed to aws June 19, 2023 19:25 — with GitHub Actions Inactive
@jchlanda jchlanda temporarily deployed to aws June 20, 2023 05:33 — with GitHub Actions Inactive
@jchlanda jchlanda temporarily deployed to aws June 20, 2023 06:11 — with GitHub Actions Inactive
@AlexeySachkov AlexeySachkov merged commit d8f6a6a into intel:sycl Jun 20, 2023
@ldrumm
Copy link
Contributor

ldrumm commented Jun 20, 2023

sorry, missed this.
But LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants