[SYCL] Make base classes for graph states #9977
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit attempts to fix the exported symbols after intel#9728 by creating templateless base classes for the different graph class specializations. This is in line with how other classes export their symbols. Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
dm-vodopyanov
approved these changes
Jun 20, 2023
EwanC
pushed a commit
to reble/llvm
that referenced
this pull request
Jun 26, 2023
The SYCL-Graphs extension code which landed in intel#9728 is a collaboration between Codeplay and Intel. When graphs specific code is touched, the teams across both Intel and Codeplay should be notified. For example, in intel#9977 no Codeplay developers were tagged (Not that we have any issues with that PR).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit attempts to fix the exported symbols after #9728 by creating templateless base classes for the different graph class specializations. This is in line with how other classes export their symbols.