Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add VA_RT_FORMAT_YUV422 for VAProfileHEVCMain422_10. #323

Closed
wants to merge 1 commit into from
Closed

Add VA_RT_FORMAT_YUV422 for VAProfileHEVCMain422_10. #323

wants to merge 1 commit into from

Conversation

wangyan42164
Copy link
Contributor

Fix issue #318.
#318

Signed-off-by: Yan Wang yan.wang@linux.intel.com

feiwan1
feiwan1 reviewed Sep 20, 2018
View reviewed changes
media_driver/linux/common/ddi/media_libva_caps.cpp Outdated
@@ -776,6 +780,10 @@ VAStatus MediaLibvaCaps::CreateDecAttributes(
// at present, latest libva have not support RGB24.
attrib.value = VA_RT_FORMAT_YUV420 | VA_RT_FORMAT_YUV422 | VA_RT_FORMAT_YUV444 | VA_RT_FORMAT_YUV400 | VA_RT_FORMAT_YUV411 | VA_RT_FORMAT_RGB16 | VA_RT_FORMAT_RGB32;
}
else if(profile == VAProfileHEVCMain422_10)
{
attrib.value = VA_RT_FORMAT_YUV422_10;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @wangyan42164 , hevc main-422-10 support 8bit/10bit of 4:0:0/4:2:0/4:2:2. So the arrib.value should include all those RT format.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @feiwan1 I updated it. But there isn't 10bit of 4:0:0. Thanks.

@wangyan42164 wangyan42164 force-pushed the HEVC422_10_format branch 2 times, most recently from 70405b0 to d21089e Compare September 20, 2018 08:32
@wangyan42164
Add VA_RT_FORMAT_YUV422 for VAProfileHEVCMain422_10.
d21089e 
Fix issue intel#318.
intel#318

Signed-off-by: Yan Wang <yan.wang@linux.intel.com>
feiwan1
feiwan1 reviewed Oct 10, 2018
View reviewed changes
media_driver/linux/common/ddi/media_libva_caps.cpp
else if(profile == VAProfileHEVCMain422_10)
{
attrib.value = VA_RT_FORMAT_YUV420 | VA_RT_FORMAT_YUV422 | VA_RT_FORMAT_YUV400 | VA_RT_FORMAT_YUV420_10 | VA_RT_FORMAT_YUV422_10;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks.

@feiwan1 feiwan1 mentioned this pull request Oct 10, 2018
Closed
@wangyan42164
Copy link
Contributor Author

#351 includes this PR.

@XinfengZhang XinfengZhang added the Duplicate Issue/PR: duplicated issue or PR label Nov 22, 2018
@XinfengZhang
Copy link
Contributor

close for #351 merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiwan1 feiwan1 feiwan1 left review comments

@Xiaogangli-intel Xiaogangli-intel Awaiting requested review from Xiaogangli-intel

@thomasli21801 thomasli21801 Awaiting requested review from thomasli21801

Assignees
No one assigned
Labels
Duplicate Issue/PR: duplicated issue or PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wangyan42164 @XinfengZhang @feiwan1