Fix HEVC 10bit encoding on KBL. (GitHub issue #320) #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Make sure CODECHAL_HEVC_MBENC_PENC kernel state initialized. 2. Add support format for 10bit. 3. Make sure CODECHAL_HEVC_MBENC_DS_COMBINED kernel state initialized. But need disable it on BXT and SKL. It should not add condition check in CodechalEncHevcStateG9::InitKernelStateMbEnc(). It should return MOS_STATUS_INVALID_PARAMETER in GetKernelHeaderAndSize(). This patch can fix intel#320. Confirmation: Current gstream seems cannot display 10bit data by vaapidecodebin. So after encoding into h265 file, I have to use ffmpeg to convert it to 8bit and display it by gst-play-1.0. It seems OK. Signed-off-by: Yan Wang <yan.wang@linux.intel.com>
|
I finished more confirmation. So the fix should work. |
|
#351 will fix decoding issue of 10bit HEVC stream. |
liangali
approved these changes
Oct 11, 2018
|
Refine it by #371 |
|
Refine it by #371 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
But need disable it on BXT and SKL. It should not add condition check
in CodechalEncHevcStateG9::InitKernelStateMbEnc(). It should return
MOS_STATUS_INVALID_PARAMETER in GetKernelHeaderAndSize().
This patch can fix #320.
Confirmation:
Current gstream seems cannot display 10bit data by vaapidecodebin.
So after encoding into h265 file, I have to use ffmpeg to convert it
to 8bit and display it by gst-play-1.0. It seems OK.
Signed-off-by: Yan Wang yan.wang@linux.intel.com